On Wed, 10 Sep 2014 17:38:31 +0200 Clemens Ladisch clemens@ladisch.de wrote:
Harley Griggs wrote:
This patch adds support for the Xonar Xense card.
The title is misleading. This is "partial support" or "stereo-only support".
Apologies. Should I resubmit with a new title or just use this thread?
+++ b/sound/pci/oxygen/xonar_pcm179x.c
- data->broken_i2c = true;
It's not. (There is no other chip at address 1001110.)
I'll remove this. I tried to use the ST as a template as much as possible. Is there a reason the ST uses this ?
- data->dacs = chip->model.dac_channels_mixer / 2;
This variable counts PCM1796 chips.
I overlooked this, will set to 1.
+static int xense_output_switch_put(struct snd_kcontrol *ctl,
struct snd_ctl_elem_value *value)+{ +...
- case 2:
gpio &= ~(GPIO_XENSE_SPEAKERS | GPIO_ST_HP_REAR);- break;
Indent.
+static int xonar_xense_mixer_init(struct oxygen *chip) +{
- unsigned int i;
- int err;
- for (i = 0; i < ARRAY_SIZE(xense_controls); ++i) {
err = snd_ctl_add(chip->card,snd_ctl_new1(&xense_controls[i], chip));if (err < 0)return err;- }
Same here.
@@ -1146,6 +1273,14 @@ int get_xonar_pcm179x_model(struct oxygen *chip,
- case 0x8428:
chip->model = model_xonar_st;chip->model.shortname = "Xonar Xense";chip->model.chip = "AV100";chip->model.init = xonar_xense_init;chip->model.mixer_init = xonar_xense_mixer_init;break;Why the empty line?
I'll fix the incorrect formatting.
Regards, Clemens _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel