Re: [alsa-devel] [PATCH 6/8] coverity fix in alsa-libs

At Thu, 18 Sep 2014 11:29:51 +0000 (GMT), Renu Tyagi wrote:

Hi, Bug Type : If lib is NULL return error to avoid strlen of NULL string File changed : simple_abst.c PFA patch6

Thanks Renu Tyagi

---

From 052755ef6fec398f4e49bd31e9e60fe42a14ba53 Mon Sep 17 00:00:00 2001 From: renu tyagi renu.tyagi@samsung.com Date: Thu, 18 Sep 2014 16:41:43 +0530 Subject: [PATCH 6/8] [simple_abst] : If lib is NULL return error to avoid strlen of NULL string.

Signed-off-by: renu tyagi renu.tyagi@samsung.com

src/mixer/simple_abst.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/mixer/simple_abst.c b/src/mixer/simple_abst.c index 9e9aaf5..67330c2 100644 --- a/src/mixer/simple_abst.c +++ b/src/mixer/simple_abst.c @@ -71,6 +71,8 @@ static int try_open(snd_mixer_class_t *class, const char *lib) int err = 0;

    path = getenv("ALSA_MIXER_SIMPLE_MODULES");

•   if (!lib)
  

•           return -ENXIO;
  

This should be put before getenv() call. Please fix and resubmit?

Takashi

    if (!path)
            path = SO_PATH;
    xlib = malloc(strlen(lib) + strlen(path) + 1 + 1);

-- 1.7.1