On Fri, Jan 06, 2023 at 09:55:43AM +0000, Ki-Seok Jo wrote:
Hi Dan,
I'm sorry. There was an opinion that the pach sent last time was inconvenient to look at because the entire patch aws modified at once.
What you should have done was just fold everything into two patches: patch 1: add the driver patch 2: add the device tree bindings
Instead you did: patch 1: add the driver patch 2: add the device tree bindings patch 3: re-write all of patch 1.
Re-writing everything is not allowed, but it's also not necessary. And also it is against the rules to submit broken code and fix it later.
It's a new driver so just fix patch 1 and resend that as a v2 patch. Same for the stuff I mentioned in my bug report.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards, dan carpenter