On Friday 16 of August 2013 12:11:51 Sascha Hauer wrote:
On Fri, Aug 16, 2013 at 05:53:58PM +0800, Nicolin Chen wrote:
On Fri, Aug 16, 2013 at 10:56:32AM +0200, Sascha Hauer wrote:
"tx<0-8>" Optional Tx clock source for spdif
playback.
If absent, will use core clock. The index from 0 to 8 is identical to the clock source list described in TxClk_Source bit of register
STC.
Multiple clock source are allowed for this tx clock source. The
driver
will select one source from them
for
each supported sample rate
according
to the clock rates of these
provided
clock sources.You mean tx<0-7>
Yes. Thank you.
Also I would make this option required. Use a dummy clock for mux inputs that are grounded for a specific SoC.
Some clocks are not from CCM and we haven't defined in imx6q-clk.txt, so in most cases we can't provide a phandle for them, eg: spdif_ext. I think it's a bit hard to force it to be 'required'. An 'optional' looks more flexible to me and a default one is ensured even if it's missing.
<&clks 0> is the dummy clock. This can be used for all input clocks not defined by the SoC.
Where does this assumption come from? Is it documented anywhere? What about cases when you have full description of clocks in device tree, with one node per clock and #clock-cells = <0>?
Best regards, Tomasz