On 2016年12月23日 23:48, Lin, Mengdong wrote:
-----Original Message----- From: alsa-devel-bounces@alsa-project.org [mailto:alsa-devel- bounces@alsa-project.org] On Behalf Of Liam Girdwood Sent: Friday, December 23, 2016 4:49 PM
This looks fine by me, Mengdong is this still unused or is it needed by a future patch ?
Hi Liam,
This "widget_control_map" is still unused now.
Could you remember why we define this map in the early phase? I guess previously we want to distinguish stand-alone controls from controls embedded in widgets. But now we process them in the same way, both in user space and kernel.
So I feel we can remove this structure.
Additionally, would you check this post to fix some warnings which you added into alsa-lib, please. [alsa-devel] [PATCH][alsa-lib] topology: fix sign-compare warning introduced to set_link_hw_config() and tplg_add_link_object() http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115896.ht...
Thanks
Takashi Sakamoto