On Thu, 2017-10-12 at 18:37 -0500, Pierre-Louis Bossart wrote:
As discussed on the alsa-devel mailing list, here is a set of patches to fix
- previous feedback on bytcht_rt5651 - no new functionality beyond
what was already reviewed 2. cosmetic issues (variables in reverse xmas tree order, etc) 3. unnecessary clock tests 4. addition of a helper to remove duplicate code across machine drivers
The last two patches were not included in the first pass, they correct an off-by-one issue which has no functional impact and remove the hard-codec compressed dailinks which don't currently work with the mainline code+publicly available firmware.
Patch 6 can be folded into 5, but it's up to you. Either choice:
Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Pierre-Louis Bossart (9): ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups ASoC: Intel: bytcr_rt5640: cosmetic fixes ASoC: Intel: cht_bsw_rt5645: cosmetic fixes ASoC: Intel: bytcht_da7213: cosmetic fixes ASoC: Intel: bytcht_es8316: remove useless code ASoC: Add helper to find codec_dai from dai_name ASoC: Intel: boards: use helper to get codec_dai ASoC: Intel: boards: fix off-by-one dailink id ASoC: Intel: boards: remove hard-coded compressed dailinks
include/sound/soc.h | 14 ++ sound/soc/intel/boards/bxt_da7219_max98357a.c | 16 +- sound/soc/intel/boards/bytcht_da7213.c | 17 +- sound/soc/intel/boards/bytcht_es8316.c | 25 +-- sound/soc/intel/boards/bytcht_nocodec.c | 10 +- sound/soc/intel/boards/bytcr_rt5640.c | 105 ++++------- sound/soc/intel/boards/bytcr_rt5651.c | 236 +++++++++++++++++++++--- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 24 +-- sound/soc/intel/boards/cht_bsw_rt5645.c | 103 ++++------- sound/soc/intel/boards/cht_bsw_rt5672.c | 24 +-- sound/soc/intel/boards/skl_nau88l25_max98357a.c | 16 +- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 16 +- 12 files changed, 318 insertions(+), 288 deletions(-)