21 Sep
2013
21 Sep
'13
12:51 p.m.
On Sat, Sep 21, 2013 at 11:47:34AM +0100, Russell King - ARM Linux wrote:
Another comment. This is broken - it will never fall through if a 'dev' is given, because of_clk_get_by_name() will always return an -EPROBE_DEFER error pointer in that case.
So this approach is unworkable.
And another comment:
This whole approach is broken - while Mark is correct that we should find a way to return -EPROBE_DEFER if a clock is specified, the solution here does not allow that - it will return -EPROBE_DEFER whenever the clock is not found _or_ is not specified.
This has the effect of making the external clock *non*optional for the kirkwood-i2s driver, which is also completely broken.