Hi Jyri
Since RFC:
- fixed commit msg typo
- added include/sound/soc.h changes too
The sematics of bitclock-master and frame-master DT parameters should depend on whether they are found from a cpu-dai or codec sub-node.
- bitclock-master in cpu-dai node means Codec-Bitclock-Slave
- frame-master in cpu-dai node means Codec-Frame-Slave
- bitclock-master in codec node means Codec-Bitclock-Master
- frame-master in codec node means Codec-Frame-Master
For example in a cpu-dai mode bitclock-master parameter should produce SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node SND_SOC_DAIFMT_CBM_* flags.
SND_SOC_DAIFMT_xxx comment indicates "codec clk/FRM" indeed. but does this "codec" means "codec chip" ?? I'm not sure.
but anyway, if my understanding is correct,
simple-audio-card,cpu { ... bitclock-master; frame-master; };
simple-audio-card,codec { ... bitclock-master; frame-master; };
This will be cpu : SND_SOC_DAIFMT_CBS_CFS codec : SND_SOC_DAIFMT_CBM_CFM
but, it is un-understandable/confusable for me, and it breaks our sound card.
${LINUX}/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts ${LINUX}/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
I guess you want like this ?
codec-bitclock-master; codec-frame-master;
simple-audio-card,cpu { ... };
simple-audio-card,codec { ... };
# And I guess [1/2] and [2/2] should be 1 patch. # otherwise, it breaks git-bisect :P
Best regards --- Kuninori Morimoto