4 Sep
2024
4 Sep
'24
2:25 p.m.
On Wed, Sep 04, 2024 at 12:07:00PM +0000, Simon Trimmer wrote:
The IRQ handling in the cs35l56 driver was purely informational. It was not necessary to support the HDA or ASoC driver functionality and added unnecessary complexity to the drivers.
As the IRQ signal GPIO line could be connected and shared with other components the handling is replaced with a regmap patch to ensure the cs35l56 IRQ sources are masked and will not generate interrupts that go unhandled.
Given that the code is there now and has been since the driver was introduced about 18 months ago what's the ongoing cost of having it? The information it's providing is notification of hardware faults, reporting those does seem useful.