Hi Laurent, Morimoto-san,
On Mon, Jan 29, 2024 at 02:27:36PM +0200, Laurent Pinchart wrote:
Hello Morimoto-san,
(CC'ing Sakari Ailus)
Thanks for cc'ing me.
On Mon, Jan 29, 2024 at 12:54:24AM +0000, Kuninori Morimoto wrote:
Hi Rob
This is v2 of port base loop patch-set
We have endpoint base functions
- of_graph_get_next_endpoint()
- of_graph_get_endpoint_count()
- for_each_endpoint_of_node()
But to handling "port" base things, it is not useful. We want to have "port" base functions, too. This patch-set adds it.
Because current existing drivers couldn't use "port" base functions, it were implemented in a different way. This patch-set doesn't try to full-replace to avoid unknown bug, try easy / quick replace only for now, but easy to know how "port" base functions are needed.
Because I can't test the driver which I can't use, non-ASoC drivers needs Tested-by, Acked-by.
The strategy sounds good to me. However, I'm wondering if you shouldn't take one more step in the core, and implement these as fwnode operations. Or is there a reason why OF is special, and iterating over ports would be useful for drivers on OF systems but not on other types of systems ?
I'd prefer that, too.
Probably we could use the existing callbacks for endpoint enumeration, for port enumeration, too, as I don't think this is performance critical in any way.