10 Feb
2020
10 Feb
'20
6:22 p.m.
On 2020-02-10 12:13, Srinivas Kandagatla wrote:
Few minor comments
+static int q6afe_tdm_set_sysclk(struct snd_soc_dai *dai,
int clk_id, unsigned int freq, int dir)+{
Why are we adding exactly duplicate function of q6afe_mi2s_set_sysclk here?
It isn't an exact duplicate.
The reason I split off the new function is because the clock IDs for PCM overlap/duplicate the clock IDs for TDM, yet the parameters to q6afe_port_set_sysclk are not the same for PCM and TDM.
- SND_SOC_DAPM_AIF_IN("QUAT_PCM_RX", NULL,
0, 0, 0, 0),This can be in single line, same for below
I will adjust these.