-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Saturday, May 02, 2015 12:33 AM To: Bard Liao Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de; Flove; Oder Chiou; John Lin; koro.chen@mediatek.com; yang.a.fang@intel.com; zhengxing@rock-chips.com Subject: Re: [PATCH 4/6] ASoC: rt5645: add device tree support
On Thu, Apr 30, 2015 at 06:18:45PM +0800, Bard Liao wrote:
+- realtek,dmic-en : Boolean. Indicate DMIC is used.
Why is this in DT as opposed to being configured by the DAPM routing or something - what is the concrete effect of this? Also...
It is for DMIC clock pin configuration. If dmic_en is true, we will set the gpio pin to be used as DMIC clock.
+- realtek,dmic1-data-pin +- realtek,dmic2-data-pin
- Indicate which pin is used for each DMIC.
...should it be combined with these (eg, if one of these properties is specified should that imply that DMIC is enabled)? We should also have something saying what the value for these properties is.
Yes, it can be combined with dmic_en. Also, I will add some descriptions for the values.
+- realtek,en-jd-func
- Boolean. Indicate if codec IRQ is used or not. It is usually used
+for JD
- and/or headset button detection.
I'm not sure I understand what this is for? I'd expect that the interrupt would be used if specified, though if a GPIO is specified I guess that'd override it.
It is for codec IRQ though it is called en-jd-func. rt5645 IRQ is not for JD only but also other functions (like button detection). Another thing is that a separate CPU pin is used for JD IRQ in some HW design. It means some HW design use their own JD function. That's what hp-det-gpio for.
------Please consider the environment before printing this e-mail.