Re: [PATCH 8/9] ASoC: dt-bindings: meson: convert axg spdif output to schema

On 02/02/2023 19:36, Jerome Brunet wrote:

Convert the DT binding documentation for the Amlogic axg spdif output to schema.

Signed-off-by: Jerome Brunet jbrunet@baylibre.com

.../bindings/sound/amlogic,axg-spdifout.txt | 25 ------ .../bindings/sound/amlogic,axg-spdifout.yaml | 83 +++++++++++++++++++ 2 files changed, 83 insertions(+), 25 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.txt create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.yaml

diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.txt b/Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.txt deleted file mode 100644 index 28381dd1f633..000000000000 --- a/Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.txt +++ /dev/null @@ -1,25 +0,0 @@ -* Amlogic Audio SPDIF Output

-Required properties: -- compatible: 'amlogic,axg-spdifout' or

•      'amlogic,g12a-spdifout' or
  

•      'amlogic,sm1-spdifout'
  

-- clocks: list of clock phandle, one for each entry clock-names. -- clock-names: should contain the following:

• • "pclk" : peripheral clock.
• • "mclk" : master clock

-- #sound-dai-cells: must be 0.

-Optional property: -- resets: phandle to the dedicated reset line of the spdif output.

-Example on the A113 SoC:

-spdifout: audio-controller@480 {

• compatible = "amlogic,axg-spdifout";
• reg = <0x0 0x480 0x0 0x50>;
• #sound-dai-cells = <0>;
• clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>,

•  <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>;
  

• clock-names = "pclk", "mclk";

-}; diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.yaml new file mode 100644 index 000000000000..c661ce7f8b9d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-spdifout.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/amlogic,axg-spdifout.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Amlogic Audio AXG SPDIF Output

+maintainers:

• • Jerome Brunet jbrunet@baylibre.com

+allOf:

• • $ref: dai-common.yaml#

+properties:

• $nodename:
• pattern: "^audio-controller@.*"
• compatible:
• oneOf:

•  - items:
  

•      - const:
  

•          amlogic,axg-spdifout
  

All usual comments apply.

•  - items:
  

•      - enum:
  

•          - amlogic,g12a-spdifout
  

•          - amlogic,sm1-spdifout
  

•      - const:
  

•          amlogic,axg-spdifout
  

• reg:
• maxItems: 1
• "#sound-dai-cells":
• const: 0
• clocks:
• items:

•  - description: Peripheral clock
  

•  - description: SPDIF output master clock
  

• clock-names:
• items:

•  - const: pclk
  

•  - const: mclk
  

+required:

• • compatible
• • reg
• • "#sound-dai-cells"
• • clocks
• • clock-names

+if:

• properties:
• compatible:

•  contains:
  

•    enum:
  

•      - amlogic,g12a-spdifout
  

•      - amlogic,sm1-spdifout
  

+then:

• properties:
• resets:

•  items:
  

•    - description: dedicated device reset line
  

• required:
• • resets

+unevaluatedProperties: false

+examples:

• • |
• #include <dt-bindings/clock/axg-audio-clkc.h>
• spdifout: audio-controller@480 {

• compatible = "amlogic,axg-spdifout";
  

Indentation.

Best regards, Krzysztof