Hello,
On Wednesday, 20 December, 2023 23:25:50, Rob Herring wrote:
On Mon, Dec 18, 2023 at 01:40:58PM +0100, Elinor Montmasson wrote:
+Optional, relevant only with the "fsl,imx-audio-generic" compatible:
- cpu-slot-width : Indicates a specific TDM slot width in bits.
- cpu-slot-num : Indicates a specific number of TDM slots per frame.
Pretty sure I've seen other bindings with TDM slot properties. A sign we need something common if we don't already have something.
That's right, "tdm-slot.txt" already defines TDM bindings, I will use them with the utility function snd_soc_of_parse_tdm_slot().
- cpu-sysclk-freq-rx : Frequency of the CPU DAI sys clock for Rx.
- cpu-sysclk-freq-tx : Frequency of the CPU DAI sys clock for Tx.
- cpu-sysclk-dir-rx-out : Boolean property. Specifies sys clock direction
- as 'out' on initialization for Rx.
- If not set, default direction is 'in'.
- cpu-sysclk-dir-tx-out : Boolean property. Specifies sys clock direction
- as 'out' on initialization for Tx.
- If not set, default direction is 'in'.
Looks like clock stuff. Use the clock binding.
simple-card defines similar properties at the dai level: "system-clock-frequency" and "system-clock-direction-out". The first is used if no "clocks" binding is specified for the dai node.
Maybe I could use a similar logic with fsl-asoc-card ? * adding a "clock-cpu" phandle property which should be the cpu clock. It will be used to retreive the frequency for both RX and TX. * keeping "cpu-sysclk-freq-rx"/"cpu-sysclk-freq-tx", which are used if no clock is provided, like "system-clock-frequency" in simple-card. * keep using "cpu-sysclk-dir-rx-out"/"cpu-sysclk-dir-tx-out", like "system-clock-direction-out" in simple card.
Also, maybe I could rename my new properties: cpu-system-clock-frequency-tx, cpu-system-clock-direction-out-rx, ... It would better match those in simple-card as they do the same thing.
Best regards, Elinor Montmasson