On Fri, 2025-04-25 at 11:31 +0530, Venkata Prasad Potturu wrote:
update chip data using dev_get_drvdata(dev->parent) instead of dev_get_platdata(dev).
BUG: kernel NULL pointer dereference, address: 0000000000000010 Call Trace:
<TASK> ? __pfx_platform_pm_resume+0x10/0x10 platform_pm_resume+0x28/0x60 dpm_run_callback+0x51/0x1a0 device_resume+0x1a6/0x2b0 dpm_resume+0x168/0x230
Fixes: e3933683b25e ("ASoC: amd: acp: Remove redundant acp_dev_data structure")
Signed-off-by: Venkata Prasad Potturu venkataprasad.potturu@amd.com
This is the first time I see an empty line between the Fixes and the Signed-off-by tags. I checked checkpatch.pl --strict and that doesn't complain, but I'm curious now, is that a subsystem thing since you have it in all 3 patches?
sound/soc/amd/acp/acp-rembrandt.c | 2 +- sound/soc/amd/acp/acp-renoir.c | 2 +- sound/soc/amd/acp/acp63.c | 2 +- sound/soc/amd/acp/acp70.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
--- snip ---
index 6d5f5ade075c..217b717e9beb 100644 --- a/sound/soc/amd/acp/acp70.c +++ b/sound/soc/amd/acp/acp70.c @@ -182,7 +182,7 @@ static void acp_acp70_audio_remove(struct platform_device *pdev)
static int acp70_pcm_resume(struct device *dev) {
- struct acp_chip_info *chip = dev_get_platdata(dev);
- struct acp_chip_info *chip = dev_get_drvdata(dev->parent); struct acp_stream *stream; struct snd_pcm_substream *substream; snd_pcm_uframes_t buf_in_frames;
Hi Venkata,
Yesterday I ran into what I believe is the issue fixed by this patch on my very recently acquired Framework 13 with a Ryzen AI 340. While I was still bisecting this I found a thread[0] of Jacek Luczak having bisected this and the revert at least solved the suspend issue for me too, though I was still getting a sound subsystem related crash[2] that looked related so was waiting for a proper fix. As a side note you might want to consider adding a Reported-by tag from Jacek.
I had mentioned this on the Framework forums[1] where Mario Limonciello helpfully pointed me at this series. I just tried your series on top of v6.15-rc4 and suspend now works. I also haven't seen the other crash I was still getting with just the revert from the previous thread. And sound still works too. So feel free to add, or ignore, my:
Tested-by: Niklas Schnelle niks@kernel.org
Thanks, Niklas
[0] https://lore.kernel.org/lkml/CADDYkjR0JG_JTQeQMAvUJvtb9RxFH6_LzV2Fr_1cnqPTgV... [1] https://community.frame.work/t/regression-framework-13-ryzen-340-doesnt-wake... [2] https://pastebin.com/pR54sve3