Re: [alsa-devel] [PATCH v3 4/5] ASoC: dwc: Add devicetree support for Designware I2S

On Fri, Dec 19, 2014 at 04:18:08PM +0000, Andrew Jackson wrote:

if (IS_ERR(dev->clk))

• return  PTR_ERR(dev->clk);
  

• return PTR_ERR(dev->clk);
  

• ret = clk_prepare(dev->clk);
• if (ret < 0)

• goto err_clk_put;
  

This isn't adding device tree support, it's adding use of clk_prepare() which is a separate change and is normally better done by converting to use clk_prepare_enable().