On 10/25/2016 02:22 PM, Lars-Peter Clausen wrote:
On 10/25/2016 12:56 PM, Sylwester Nawrocki wrote:
<...>
Nice patch. One nice-to-have change request, can you split this into two patches, one which removes the last users and one patch which removes support for it from the framework?
OK, I've made such split, looks cleaner this way indeed.
Having the new DMA map framework should also allow us to eventually remove the channel request in dmaengine_pcm_new() once all users of filter functions have gone.
I've started working on removing all DMA filter uses from sound/soc/samsung, hopefully it's ready in coming or next kernel release. I need to add couple more DMA map tables and support for DMA slave map to the PL080 controller.
[...]
@@ -284,12 +283,9 @@ static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd) if (!substream) continue;
dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);if (!pcm->chan[i] &&(pcm->flags & SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME))
if (!pcm->chan[i] && config->chan_names[i]) pcm->chan[i] = dma_request_slave_channel(dev,
dma_data->chan_name);
config->chan_names[i]);I think this can be removed altogether. The only reason why we did the delayed request is because the name would have not been available when initially trying to request the channel when the PCM device is registered.
Thanks for the hint, I will remove that call in v2. I suspected it might not be necessary any more but was afraid a bit of introducing a breakage.
Now the patch will be basically a revert of
commit ea73b7ddf13548afd666373dc5e26ee7c812a3fe ASoC: dmaengine: Support custom channel names