Re: [alsa-devel] [PATCH v2] sound: pci: ctxfi: pr_* replaced with dev_*

15 Sep 2014

On Mon, 2014-09-15 at 19:39 +0530, Sudip Mukherjee wrote:
...
pr_* macros replaced with dev_* as they are more preffered over pr_*.
[]
...

diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
[]
...
@@ -1282,8 +1282,8 @@ static int atc_identify_card(struct ct_atc *atc, unsigned int ssid)
   p = snd_pci_quirk_lookup_id(vendor_id, device_id, list);
   if (p) {
   	if (p->value < 0) {

	pr_err("ctxfi: Device %04x:%04x is black-listed\n",


	       vendor_id, device_id);




	dev_err(atc->card->dev, "ctxfi: Device %04x:%04x is black-listed\n",


		vendor_id, device_id);



You should probably remove the "ctxfi: " from the dev_<level>
uses as the card->dev name is emitted by dev_err
dev_err(atc->card->dev, "Device %04x:%04x is black-listed\n",
    			vendor_id, device_id);
etc...

    

Joe Perches