On 03/09/2024 11:08, Ki-Seok Jo wrote:
On 03/09/2024 10:39, Ki-Seok Jo wrote:
On Tue, Sep 03, 2024 at 02:44:34PM +0900, Kiseok Jo wrote:
Signed-off-by: Kiseok Jo kiseok.jo@irondevice.com
Empty commit? Read submitting-patches.
Okay I'll add next patch.
Please run scripts/checkpatch.pl and fix reported warnings. Then please run and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
When I checked, I didn't encounter any errors or warnings when using
'checkpatch.pl'.
What options might be needed?
That's not true and I am not happy that I need to prove to you obvious thing. You do not need any options. Look:
WARNING: Missing commit description - Add an appropriate one
You could at least now double check if reviewer pointed it out instead of immediately disagreeing with review.
I have no intention of opposing the content. I am asking again because I didn't receive any warnings when I did the following, and I suspect I might have done something wrong.
./scripts/checkpatch.pl Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml
total: 0 errors, 0 warnings, 54 lines checked
Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml has no obvious style problems and is ready for submission.
I was under the impression that this only applied to patched files as described above. It turns out it can also be used with patch files. Thank you for the useful information!
That's not how you run checkpatch. You run it on the patch. Please read submitting-patches document. It explains everything.
Best regards, Krzysztof