Re: [PATCH 3/7] RDMA/qib: don't pass bogus GFP_ flags to dma_alloc_coherent

15 Nov 2022


      On Sun, Nov 13, 2022 at 05:35:31PM +0100, Christoph Hellwig wrote:
...
dma_alloc_coherent is an opaque allocator that only uses the GFP_ flags
for allocation context control.  Don't pass GFP_USER which doesn't make
sense for a kernel DMA allocation or __GFP_COMP which makes no sense
for an allocation that can't in any way be converted to a page pointer.
Signed-off-by: Christoph Hellwig hch@lst.de
drivers/infiniband/hw/qib/qib_iba6120.c |  2 +-
 drivers/infiniband/hw/qib/qib_init.c    | 21 ++++-----------------
 2 files changed, 5 insertions(+), 18 deletions(-)
Same same
Acked-by: Jason Gunthorpe jgg@nvidia.com
Jason