Re: [alsa-devel] [RFC PATCH v2 1/3] ep93xx i2s audio driver

Hi,

On Wednesday 26 May 2010 08:09:46 ext Ryan Mallon wrote:

Add ep93xx i2s audio driver

..

+static void ep93xx_i2s_disable(struct ep93xx_i2s_info *info) +{

•   int i;
  

•   /* Disable fifos */
  

•   for (i = 0; i < 3; i++) {
  

•           ep93xx_i2s_write_reg(info, EP93XX_I2S_RX0EN + (i * 4), 0);
  

•           ep93xx_i2s_write_reg(info, EP93XX_I2S_TX0EN + (i * 4), 0);
  

•   }
  

•   /* Disable i2s */
  

•   ep93xx_i2s_write_reg(info, EP93XX_I2S_GLCTRL, 0);
  

•   /* Disable clocks */
  

•   clk_disable(info->lrclk);
  

•   clk_disable(info->sclk);
  

•   clk_disable(info->mclk);
  

+}

I think this will break the other stream in duplex case, since you stop both FIFOs, and also disable the clocks. Does the ep93xx supports duplex audio?