On Thu, Nov 08, 2018 at 02:37:43PM +0000, Daniel Baluta wrote:
Hi Vinod,
Just noticed that this patch is similar with this one for crecord
http://git.alsa-project.org/?p=tinycompress.git;a=commit;h=e8e36567438c 16a5121943205a0cd8c63924d0d8
So, I think we can remove the RFC tag :).
thanks, Daniel. On Lu, 2018-11-05 at 14:23 +0000, Daniel Baluta wrote:
cplay first writes frag * fragment_size and then it only writes one fragment at a time.
This means for example than if the user supplied a buffer_size it will only be used for the first write.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com
I noticed this while investigating why cplay prints buffer_size as 0 when not specified as command line argument to cplay.
I also noticed that cred always reads frag * frament_size, so I think this patch should be OK, but marking it as RFC to get your thoughts.
Reviewed-by: Charles Keepax ckeepax@opensource.cirrus.com
Yeah looks good to me.
Thanks, Charles