Re: [alsa-devel] [PATCH -next] ASoC: fsl_micfil: Remove set but not used variable 'osr'

17 Apr 2019

On Wed, Apr 17, 2019 at 06:25:11PM +0300, Daniel Baluta wrote:
...
Looks good to me. Just one question for Cosmin:
...
...

diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
index 40c07e7..f7f2d29 100644
--- a/sound/soc/fsl/fsl_micfil.c
+++ b/sound/soc/fsl/fsl_micfil.c
@@ -151,12 +151,9 @@ static inline int get_clk_div(struct fsl_micfil *micfil,
 {
        u32 ctrl2_reg;
        long mclk_rate;

  int osr;
  int clk_div;

  regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);



I noticed now that we also read ctrl2_reg without using it. Is this as intended?
For Cosmin,
Same question here.
Btw, I just noticed that the initial patch of adding this driver
did not seemly include most of FSL maintainers/reviewers. Please
run get_maintainer.pl to add all listed reviewers when sending a
change to the maillist.
Thanks
Nicolin

    

Nicolin Chen