On Tuesday 30 November 2010 16:30:13 ext Mark Brown wrote:
On Tue, Nov 30, 2010 at 04:00:04PM +0200, Peter Ujfalusi wrote:
Users can choose to not add the DAPM routes provided by the amp driver, but use the direct enable/disable interface from machine driver with SND_SOC_DAPM_HP's event callback. In some cases this method must be used to make the audio path pop noise free.
Is there any situation where it would undesirable to do this? If not it'd seem better to just make the driver do this always.
You mean to not have DAPM widgets/routes in the tpa6130a2 driver, and only have a function, which can be used to turn on/off the amp? The original [1] (first version) of the tpa6130a2 driver only had DAPM_HP widget. It has been changed based on the comments.
+int tpa6130a2_stereo_enable(int enable) +{
It'd be much nicer if this took a CODEC as an argument - even if the implementation doesn't actually use it yet it'd be better to have an interface which has an idea that there may be multiple instances of the device.
Sure, I will do that.
[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022034.htm...