30 Apr
2015
30 Apr
'15
11:52 a.m.
At Thu, 30 Apr 2015 15:12:21 +0530, Vinod Koul wrote:
On Wed, Apr 29, 2015 at 02:31:02PM +0200, Takashi Iwai wrote:
At Wed, 29 Apr 2015 01:24:27 +0530, Vinod Koul wrote:
+static struct snd_soc_dai_driver soc_hda_platform_dai[] = { +{
- .name = "System Pin",
- .ops = &hda_pcm_dai_ops,
- .playback = {
.stream_name = "System Playback",
.channels_min = HDA_MONO,
.channels_max = HDA_STEREO,
.rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_8000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
- },
- .capture = {
.stream_name = "System Capture",
.channels_min = HDA_MONO,
.channels_max = HDA_STEREO,
.rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000,
.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
Is it really S24_LE? It's packed in lower 3 bytes of 4 bytes format.
Yup, we do use S24_LE, thats very common on our DSP based systems
OK.
- },
+}, +{
- .name = "Deepbuffer Pin",
- .ops = &hda_pcm_dai_ops,
- .playback = {
.stream_name = "Deepbuffer Playback",
.channels_min = HDA_STEREO,
.channels_max = HDA_STEREO,
.rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
- },
+}, +{
- .name = "LowLatency Pin",
- .ops = &hda_pcm_dai_ops,
- .playback = {
.stream_name = "Low Latency Playback",
.channels_min = HDA_STEREO,
.channels_max = HDA_STEREO,
.rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
- },
Are there no S32_LE support at all for all dais?
No, just 16 and 24 bits :)
Hm, so this restriction remains also for decoupled from DSP?
All HDA codecs supports 24bit formats (in S32_LE form), but in your patch, 24bit format is supported only for System Capture.
Takashi