Re: [alsa-devel] [PATCHv2 4/7] ASoC: TWL6030: Manual power-up/down sequences

On Fri, Sep 25, 2009 at 09:03:08PM -0500, Lopez Cruz, Misael wrote:

• 	/* sync registers updated during power-up sequence */
  

• 	twl6030_write_reg_cache(codec, TWL6030_REG_NCPCTL,
  

• 				0x81);
  

• 	twl6030_write_reg_cache(codec, TWL6030_REG_LDOCTL,
  

• 				0x45);
  

• 	twl6030_write_reg_cache(codec, TWL6030_REG_LPPLLCTL,
  

• 				0x01);
  

It might be nicer if these were read from the hardware instead of being set to magic values. Otherwise this looks OK.