On Tue, 2015-01-13 at 20:50 +0100, Takashi Iwai wrote:
At Tue, 13 Jan 2015 18:26:18 +0000, Liam Girdwood wrote:
On Tue, 2015-01-13 at 17:52 +0100, Takashi Iwai wrote:
At Tue, 13 Jan 2015 11:00:39 +0800, han.lu@intel.com wrote:
From: "Lu, Han" han.lu@intel.com
with cset command, UCM set kcontrol parameters directly: cset "name='<KCONTROL_NAME>' 1,2<,3,...>" This patch enables UCM to set kcontrol with parameters from configure file: bcsetf "name='<KCONTROL_NAME>' <path/to/file>" where "bcsetf" is a newly added keyword alongside of "cset", to indicate binary cset with file; and <path/to/file> is the configure file storing parameters in bytes array, up to 512 Bytes (the maxim value that struct snd_ctl_elem_value can hold).
Why binary? It's not portable. You can't carry it to a different architecture.
The intention here is that the binary data is not meant for the host but for audio DSPs so it's just passed by UCM/ALSA as raw data.
In that case, we should limit to certain element data types. Otherwise people would abuse it for passing data even to integer or enum ctls.
And of course it'd be better to clarify the reason in the patch description :)
BTW, I'm still not so convinced by bcsetf... Can't it be more verbose or readable?
Yeah, we should probably make it more readable :)
Lu Han will probably have some naming suggestions shortly....
Liam