12 Mar
2014
12 Mar
'14
5:07 a.m.
Hi Mark, Jyri
Since RFC:
- fixed commit msg typo
- added include/sound/soc.h changes too
The sematics of bitclock-master and frame-master DT parameters should depend on whether they are found from a cpu-dai or codec sub-node.
- bitclock-master in cpu-dai node means Codec-Bitclock-Slave
- frame-master in cpu-dai node means Codec-Frame-Slave
- bitclock-master in codec node means Codec-Bitclock-Master
- frame-master in codec node means Codec-Frame-Master
For example in a cpu-dai mode bitclock-master parameter should produce SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node SND_SOC_DAIFMT_CBM_* flags.
I had misunderstood about SND_SOC_DAIFMT_xxx So, please ignore my previous comment.
But, I wounder, if cpu/codec use identical format flags, then, asoc_simple_dai don't need fmt ?
struct asoc_simple_dai { const char *name; unsigned int fmt; <= we can/should remove this ? unsigned int sysclk; };