16 May
2010
16 May
'10
8:31 p.m.
On Sat, May 15, 2010 at 05:30:03PM +0200, apatard@mandriva.com wrote:
This patch enables support for the i2s controller available on orion/kirkwood platforms
Signed-off-by: Arnaud Patard apatard@mandriva.com
All looks sensible enough, CCing in Liam. One thing...
- if (status & ~(ORION_INT_CAUSE_PLAY_BYTES | \
ORION_INT_CAUSE_REC_BYTES)) {printk(KERN_WARNING "%s: unexpected interrupt %lx\n",__func__, status);return IRQ_HANDLED;- }
Did the driver really handle the interrupt here? It's not even written an ack back so IRQ_NONE might be a better response (the problem with using IRQ_NONE before was that the driver may have handled some transfer interrupts before it got the empty status).