Re: [alsa-devel] [PATCH] speaker-test: Support S24_3LE sample format

On Fri, 02 Mar 2018 15:31:04 +0100, Julian Scheel wrote:

Implement support signed 24 bit samples, packed in 3 bytes.

Signed-off-by: Julian Scheel julian@jusst.de

Thanks for the patch. The change itself is OK, but now I noticed that there are way too many open-codes for the same stuff. Let's kick them out and then apply the support for a new format.

I cleaned up the code now in git tree. Could you rebase your patch? Also, it'd be better to have both *_LE and *_BE formats. It shouldn't be hard.

thanks,

Takashi