Re: [alsa-devel] [PATCH v5] sound/soc/lapis: add machine driver for ML7213 Carrier Board

On Thu, Feb 23, 2012 at 02:46:51PM +0900, Tomoya MORINAGA wrote:

 This option enables support for the AC Link Controllers in ML7213 IOH SoC.

+config SND_SOC_ML7213_MACHINE

• tristate "ML7213 IOH ASoC machine driver"
• select SND_SOC_ML7213_PLATFORM
• help

•  This is ASoC machine driver for ML7213 IOH
  

This needs to depend on the CODEC as well, how have you tested?

You're also missing a blank line between this and the previous stanza.

• default:

• pr_err("%s: Failed not support format\n", __func__);
  

• return -EINVAL;
  

• break;
  

return followed by break isn't entirely sensible.

+static struct platform_device *ioh_snd_device;

+static int __init ioh_i2s_init(void) +{

• int ret;
• ioh_snd_device = platform_device_alloc("soc-audio", -1);
• if (!ioh_snd_device)

• return -ENOMEM;
  

Use snd_soc_register_card() and a real device.