Hi,
On Tue, May 25, 2021 at 09:33:49AM +0200, Takashi Iwai wrote:
On Fri, 07 May 2021 16:03:24 +0200, Maxime Ripard wrote:
In some situations, like a codec probe, we need to provide an IEC status default but don't have access to the sampling rate and width yet since no stream has been configured yet.
Each and every driver has its own default, whereas the core iec958 code also has some buried in the snd_pcm_create_iec958_consumer functions.
Let's split these functions in two to provide a default that doesn't rely on the sampling rate and width, and another function to fill them when available.
Signed-off-by: Maxime Ripard maxime@cerno.tech
The changes look almost good, but please use EXPORT_SYMBOL_GPL() for newly introduced symbols.
Ack, I'll change it.
Also, it'd be worth to mention that some bits update are done only for the default values; if a rate value has been already set, it won't be overridden by this *_fill_*() call, that's the intentional behavior, right?
Sorry, I forgot to put a commit log on the patch 2 that implements this.
My intent was to provide a default in the probe, but if it was ever overridden, we would return it in the control afterwards and pass it along to the hw_params (and later prepare) hooks
I'll add a commit message
Last but not least, the subject prefix should be "ALSA:" in general :)
Ok, I'll change it then
Thanks! Maxime