At Wed, 28 Nov 2007 02:19:03 -0500, Dave Dillow wrote:
+static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-MAX */ +static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; /* ID for this card */ +static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; /* Enable this card */
Can there be multiple SIS7019 devices? If there can only a single device, let's avoid array.
+module_param_array(index, int, NULL, 0444); +MODULE_PARM_DESC(index, "Index value for SiS7019 Audio Accelerator."); +module_param_array(id, charp, NULL, 0444); +MODULE_PARM_DESC(id, "ID string for SiS7019 Audio Accelerator."); +module_param_array(enable, bool, NULL, 0444); +MODULE_PARM_DESC(enable, "Enable SiS7019 Audio Accelerator.");
Ditto.
+static struct snd_pcm_hardware sis_playback_hw_info = {
- .info = (SNDRV_PCM_INFO_MMAP |
SNDRV_PCM_INFO_MMAP_VALID |SNDRV_PCM_INFO_INTERLEAVED |SNDRV_PCM_INFO_BLOCK_TRANSFER |SNDRV_PCM_INFO_SYNC_START |SNDRV_PCM_INFO_RESUME),
SNDRV_PCM_INFO_SYNC_START seems invalid here. It's not implemented in the driver.
+static void __sis_map_silence(struct sis7019 *sis)
Any reason to use __ prefix?
Thanks,
Takashi