Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote:

• wm8731->mclk = devm_clk_get(&spi->dev, "mclk");
• if (IS_ERR(wm8731->mclk)) {

•    wm8731->mclk = NULL;
  

•    dev_warn(&spi->dev, "assuming static MCLK\n");
  

• }

This is broken for both deferred probe and in the case where the clock API genuinely returns a NULL clock. Other than that it's the kind of thing that we've done for some other drivers, though it's not good to have to do this. Check them for correct behaviour.

The coding style is also not right for the whole patch and there's a lot of missing error checking.