Re: [alsa-devel] [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()

On 12/21/18 11:11 AM, Dan Carpenter wrote:

We accidentally call mutex_unlock(&pcm512x->mutex); twice in a row.

I re-wrote the error handling to use "goto unlock;" instead of returning directly. Hopefully, it makes the code a little simpler.

Fixes: 3500f1c589e9 ("ASoC: pcm512x: Implement the digital_mute interface") Signed-off-by: Dan Carpenterdan.carpenter@oracle.com

---

sound/soc/codecs/pcm512x.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)

Reviewed-by: Dimitris Papavasiliou dpapavas@gmail.com