On 3/17/20 11:10 PM, "mac.chiang@intel.com--cc=pierre-louis.bossart"@linux.intel.com wrote:
Fixed email
From: Mac Chiang mac.chiang@intel.com
support woofer stereo speakers individually
Both the commit title and message are a bit misleading. should be something like
" ASoC: Intel: boards: cml_rt1011: split woofer and tweeter support
Support Woofer stereo speakers by default and optionally Tweeter stereo speakers with a DMI quirk "
The rest looks mostly good except for one memory allocation test and a couple of nitpicks. Care to send a v3?
Thanks. -Pierre
@@ -302,10 +378,8 @@ SND_SOC_DAILINK_DEF(ssp1_pin, DAILINK_COMP_ARRAY(COMP_CPU("SSP1 Pin"))); SND_SOC_DAILINK_DEF(ssp1_codec, DAILINK_COMP_ARRAY(
- /* WL */ COMP_CODEC("i2c-10EC1011:00", CML_RT1011_CODEC_DAI),
- /* WR */ COMP_CODEC("i2c-10EC1011:01", CML_RT1011_CODEC_DAI),
- /* TL */ COMP_CODEC("i2c-10EC1011:02", CML_RT1011_CODEC_DAI),
- /* TR */ COMP_CODEC("i2c-10EC1011:03", CML_RT1011_CODEC_DAI)));
/* WL */ COMP_CODEC("i2c-10EC1011:00", CML_RT1011_CODEC_DAI),/* WR */ COMP_CODEC("i2c-10EC1011:01", CML_RT1011_CODEC_DAI)));
is the alignment change needed?
@@ -456,6 +525,65 @@ static int snd_cml_rt1011_probe(struct platform_device *pdev) snd_soc_card_cml.dev = &pdev->dev; platform_name = mach->mach_params.platform;
- dmi_check_system(sof_rt1011_quirk_table);
- dev_info(&pdev->dev, "sof_rt1011_quirk = %lx\n", sof_rt1011_quirk);
- if (sof_rt1011_quirk & (SOF_RT1011_SPEAKER_TL |
SOF_RT1011_SPEAKER_TR)) {rt1011_dais_confs = devm_kzalloc(&pdev->dev,sizeof(struct snd_soc_codec_conf) *SPK_CH, GFP_KERNEL);if (!rt1011_dais_confs)return -ENOMEM;rt1011_dais_components = devm_kzalloc(&pdev->dev,sizeof(struct snd_soc_dai_link_component) *SPK_CH, GFP_KERNEL);if (!rt1011_dais_components)return -ENOMEM;for (i = 0; i < SPK_CH; i++) {rt1011_dais_confs[i].dlc.name = devm_kasprintf(&pdev->dev,GFP_KERNEL,"i2c-10EC1011:0%d",i);
if (!rt1011_dais_confs[i].dlc.name) return -ENOMEM;
switch (i) {case 0:rt1011_dais_confs[i].name_prefix = "WL";break;
spurious newline?
case 1: