On 08/11/2023 11:43:32+0100, Krzysztof Kozlowski wrote:
Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that:
- Compatibles should be specific.
- We should add new compatibles in case of bugs or features.
Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Acked-by: Alexandre Belloni alexandre.belloni@bootlin.com
I propose to take the patch through Samsung SoC (me). See cover letter for explanation.
Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml index d51b236939bf..bf4e11d6dffb 100644 --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml @@ -17,6 +17,11 @@ properties: - samsung,s3c2416-rtc - samsung,s3c2443-rtc - samsung,s3c6410-rtc
- items:- enum:- samsung,exynos7-rtc- samsung,exynos850-rtc- const: samsung,s3c6410-rtc - const: samsung,exynos3250-rtc deprecated: true-- 2.34.1