Re: [alsa-devel] [PATCH 1/2] ASoC: rt5677: Add a configuration option for LDO2_POW pin

On Tue, Sep 16, 2014 at 10:28:58PM -0700, Anatol Pomozov wrote:

• if (gpio_is_valid(rt5677->pow_ldo2)) {

• ret = devm_gpio_request_one(&i2c->dev, rt5677->pow_ldo2,
  

• 			    GPIOF_OUT_INIT_HIGH,
  

• 			    "RT5677 POW_LDO2");
  

• if (ret < 0) {
  

• 	dev_err(&i2c->dev, "Failed to request POW_LDO2 %d: %d\n",
  

• 		rt5677->pow_ldo2, ret);
  

• 	return ret;
  

• }
  

• msleep(10);
  

• }

This doesn't disable the GPIO on remove which I'd expect, along with management at at least suspend and resume if not at runtime. The removal is the most important one though.