On Sep 19 2018 22:36, Emmanuel Gil Peyrot wrote:
On Wed, Sep 19, 2018 at 10:22:48PM +0900, Takashi Sakamoto wrote:
On Sep 18 2018 22:42, Emmanuel Gil Peyrot wrote:
From: Emmanuel Gil Peyrot linkmauve@linkmauve.fr
[…]
@@ -174,45 +174,48 @@ class MixerWindow(Gtk.Window): self.connect('destroy', lambda w: Gtk.main_quit()) self.set_title("Hardware Mixer Volumes")
vbox = Gtk.VBox()
vbox = Gtk.Grid()vbox.set_orientation(Gtk.Orientation.VERTICAL)As long as I know, g-i of Gtk+3 has both of 'Gtk.VBox' and 'Gtk.HBox'. I don't object to this patchset if they satisfy your demand, however from my curiosity would I ask you the reason to use 'Gtk.Grid' instead of them? This patch includes no lines to add rows/colums and to me no requirement to use grid in this point.
The Gtk.VBox documentation[1] says:
“Deprecated since version 3.2: You can use Gtk.Box.new() with Gtk.Orientation.VERTICAL instead, which is a quick and easy change. But the recommendation is to switch to Gtk.Grid, since Gtk.Box is going to go away eventually. See Migrating from other containers to GtkGrid.”
Since no backwards incompatible change can be made in GTK+ 3.x, it is still present as of 3.24, but it has been removed in 4.0 and it’d be nice to support this one already when it’ll be released. :)
Thanks for your explanation. Indeed, gtk+ community obsoleted gtk_vbox[1] and gtk_hbox[2] in their v3.89.1 release.
(g-i is a specification for metadata format for API of library. PyGobject is a Python binding to handle the metadata and library. The status of public API is decided by the library itself.)
Furthermore, gtk+ community published an instruction to use gtk_grid instead of gtk_box[3].
Totally, your changes are good enough.
[1] Delete gtkvbox.{c,h} (fe24fcbc) · Commits · GNOME / gtk · GitLab https://gitlab.gnome.org/GNOME/gtk/commit/fe24fcbc3e71bcf7e222a4106bf6e3f7ec... [2] Remove GtkHBox (fb3d9022) · Commits · GNOME / gtk · GitLab https://gitlab.gnome.org/GNOME/gtk/commit/fb3d9022ad98049c887cec5aeffd6b73de... [3] Migrating from other containers to GtkGrid: GTK+ 3 Reference Manual https://developer.gnome.org/gtk3/stable/gtk-migrating-GtkGrid.html
Thanks
Takashi Sakamoto