On Fri, 2017-08-25 at 10:24 -0400, Tom Rini wrote:
On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
+John
On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model.
Tom, one more question.
Just to be clear, the below has nothing to do with this patch or my patches against rt5677.c. It points to a possible separate issue.
Apparently you are the one who tested the commit 89128534f925 ("ASoC: rt5677: Add ACPI support") year ago.
Yes.
The commit states that ACPI properties that are used in Chromebook Pixel 2015 is non-standard (not the same as for DT).
However, DSDT shows the opposite!
Interesting. I'm not an ACPI person, I just tested what John came up with.
I would like to ask yuo and John what is the status of that currently? Do we have any publicly available laptop with non-standard properties?
Is there any sort of "build date" or similar in the dump I provided yesterday?
Header has this
* Signature "DSDT" * Length 0x00004720 (18208) * Revision 0x02 * Checksum 0x6E * OEM ID "COREv4" * OEM Table ID "COREBOOT" * OEM Revision 0x20110725 (537986853) * Compiler ID "INTL" * Compiler Version 0x20130117 (538116375)
...if it's ever changed.
Every once in a while my laptop accidentally books into ChromeOS and then it might grab and apply some updates and it's not impossible that Google updated things in the interim.
I'm quite happy to test patches or provide further dumps / etc from my system. You might want to start by talking with the person behind https://github.com/raphael/linux-samus to see if they know more about different versions of the hardware or at least point you towards more testers. Thanks!
It's just a heads up to point to a potential problem with this board. I suspect Google would take care of this.