Re: [alsa-devel] [PATCH 5/5] ASoC: sh: fsi: add FSI-WM8978 support

Hi Mark

Thank you for checking patch

...

+config SND_FSI_WM8978

• tristate "FSI-WM8978 sound support"
• depends on SND_SOC_SH4_FSI
• select SND_SOC_WM8978

•    select SND_FSI_CODEC
  

• help

•  This option enables generic sound support for the
  

•  FSI - WM8978 unit
  

Rather than having an explicit Kconfig option like this it might be more sensible to have the boards select their CODEC driver. We should only build the CODEC driver if the user enables the subsystem IIRC so this shouldn't be a big cost. You could then just have a single Kconfig for the simple driver.

OK. I understand. I guess this opinion is not only for this "FSI-WM8978" but also for existing cards.

Best regards --- Kuninori Morimoto