On 10/26/22 04:19, Srinivas Kandagatla wrote:
Thanks Pierre,
On 21/10/2022 18:09, Pierre-Louis Bossart wrote:
On 10/21/22 11:51, Srinivas Kandagatla wrote:
SubGraph and Module Instance ids take 32 bits, so use idr_alloc_u32 instead of idr_alloc to able to accomdate valid ranges.
typo: accommodate.
will fix it in next version
Also worth checking https://www.kernel.org/doc/html/latest/core-api/idr.html "The IDR interface is deprecated; please use the XArray instead."
Thanks for this hit, this looks really good and specially lookups without Locking, this could cleanup the code a bit.
Having said that I would still like this patch go as it is with idr for now, and I can plan to rework on converting idr to xa later, as there are few more Qcom Audio drivers that have usage of idr.
sounds good.