On Sat, Aug 7, 2010 at 18:29, Mark Brown wrote:
On 7 Aug 2010, at 22:14, Mike Frysinger wrote:
On Sat, Aug 7, 2010 at 17:08, Mark Brown wrote:
It'd be really helpful if you could do a bit more pre-review on the stuff you're posting, especially where you've got a bunch of drivers that follow similar patterns and are going to generate exactly the same feedback. Posting a large batch of patches at once isn't a problem but if you're sending additional patches later on it'd be helpful to take into account the feedback that has already been given on prior serieses.
probably, but i'm not familiar with the ASoC stuff to fix/review any of this. i'll open another tracker item for these codecs.
It'd probably be enough to just avoid posting additional batches of patches without incorporating previous review, either by just posting everything in one series or by holding off on later ones after getting the first batch of review. The reason I mentioned this was that I'd already reviewed previous postings (and seen that you'd read my review) but was noticing many of the same issues cropping up in the new postings.
i'd like to have sent these out as one batch, but it takes time for me to clean up the commits being sent to me. you'd probably barf all over the changesets that i have to process ;).
i dont have any other codec drivers atm though. just bug fixes that i need to further clean up/split/document/etc... -mike