Re: [alsa-devel] [PATCH - ice1724 1/4] ALSA: ice1724 - Create capture pcm only for ADC-enabled configurations

At Thu, 5 Jan 2012 22:01:55 +0100, pavel.hofman@ivitera.com wrote:

From: Pavel Hofman pavel.hofman@ivitera.com

Add the capture pcm only if there is at least one ADC configured in the SYSCONF register.

Signed-off-by: Pavel Hofman pavel.hofman@ivitera.com

diff --git a/pci/ice1712/ice1724.c b/pci/ice1712/ice1724.c index 4353e76..2a0be2c 100644 --- a/pci/ice1712/ice1724.c +++ b/pci/ice1712/ice1724.c @@ -1117,14 +1117,18 @@ static struct snd_pcm_ops snd_vt1724_capture_pro_ops = { static int __devinit snd_vt1724_pcm_profi(struct snd_ice1712 *ice, int device) { struct snd_pcm *pcm;

• int err;

• int capt, err;

• err = snd_pcm_new(ice->card, "ICE1724", device, 1, 1, &pcm);

• capt = (~ice->eeprom.data[ICE_EEP2_SYSCONF] & VT1724_CFG_ADC_MASK) ?

• 1 : 0;
  

Are you sure that this is correct? I thought the value 0 means 1 ADC, 1 is two ADCS, etc.

thanks,

Takashi