Re: [alsa-devel] [PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

On Tue, Dec 19, 2017 at 02:54:25PM -0600, Steven Eckhoff wrote:

• SOC_ENUM("MBC Band1 Level Detect Switch",

• mbc_level_detection_enums[0]),
  

• SOC_ENUM("MBC Band2 Level Detect Switch",

• mbc_level_detection_enums[1]),
  

• SOC_ENUM("MBC Band3 Level Detect Switch",

• mbc_level_detection_enums[2]),
  

• SOC_ENUM("MBC Band1 Level Detect Win Switch",

• mbc_level_detection_window_enums[0]),
  

• SOC_ENUM("MBC Band2 Level Detect Win Switch",

• mbc_level_detection_window_enums[1]),
  

• SOC_ENUM("MBC Band3 Level Detect Win Switch",

• mbc_level_detection_window_enums[2]),
  

These are enums so they should probably not have Switch at the end of their name, I suspect that might confuse userspace somehow.

• SOC_SINGLE("MBC1 Phase Invert", R_DACMBCMUG1, FB_DACMBCMUG1_PHASE,

• 1, 0),
  

While this is an on/off switch (for inversion) so it ought to end in Switch. Otherwise this driver looks good I think, just those couple of small things so I'll apply - please send followup patches fixing.