Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional()

On 02/04/2020 19:21:35+0800, Tang Bin wrote:

In order to simply code,because platform_get_irq() already has dev_err() message.

But what I see is a dev_dbg message so your patch actually changes the behaviour when debugging is not enabled.

Signed-off-by: Tang Bin tangbin@cmss.chinamobile.com

sound/atmel/ac97c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index a1dce9725..25cfd5710 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) return -ENXIO; }

• irq = platform_get_irq(pdev, 0);

• irq = platform_get_irq_optional(pdev, 0); if (irq < 0) { dev_dbg(&pdev->dev, "could not get irq: %d\n", irq); return irq;

-- 2.20.1.windows.1