On Thu, Nov 20, 2008 at 6:14 AM, Mark Brown broonie@sirena.org.uk wrote:
On Thu, Nov 20, 2008 at 04:02:43PM +0200, Peter Ujfalusi wrote:
My plan is to add _all_ (ok, almost all) the features we can get with TWLx030... So instead of having 'only' one possible route from DACl2/DACR2, I have implemented in a reverse order:
...
With this mode one can enable whatever combination of routing he/she needs from TWL.
Since these channels are really 'independent' inside of TWL, making the routing/mixing flexible (you might say extremely flexible) could make sense.
This is good - an ASoC codec driver should expose as much functionality of the codec as possible and let user space configure it at runtime. See for example the WM8900 or WM8990 drivers for examples of codecs with fairly complex audio routing.
Agreed! This is a really good thing to do.
Had I not been under a lot of time pressure when doing the original version of the driver I would have taken this approach myself.
I'm glad to see that you are tackling this. Peter, you should post your patches for comment. Might help speed things along if we get more folks looking and contributing.
Steve