On 07/12/17 09:53, Philippe Ombredanne wrote:
Srinivas,
On Tue, Dec 5, 2017 at 11:17 PM, srinivas.kandagatla@linaro.org wrote:
From: Srinivas Kandagatla srinivas.kandagatla@linaro.org
This patch adds support toi APR bus (Asynchronous Packet Router) driver. ARP driver is made as a bus driver so that the apr devices can added removed more dynamically depending on the state of the services on the dsp. APR is used for communication between application processor and QDSP to use services on QDSP like Audio and others.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
[]
--- /dev/null +++ b/drivers/soc/qcom/apr.c @@ -0,0 +1,395 @@ +/* SPDX-License-Identifier: GPL-2.0 +* Copyright (c) 2011-2016, The Linux Foundation +* Copyright (c) 2017, Linaro Limited +*/
Accept my apologies as I am nitpicking there, but I think that Linus's preferred style for the SPDX id line is the C++ style //.
Thanks for review, I just realized this, I will fix this in next version.
And while you are at it since these is only license and copyrights you could go with this all the way, as in this:
+// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2011-2016, The Linux Foundation +// Copyright (c) 2017, Linaro Limited
Yep, thanks,
srini
You can check the doc patches posted by Thomas (tglx) and earlier comments from Linus wrt comment style and his good rationale for these.