Minor comment inline On Thu, Sep 28, 2017 at 2:59 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
ALSA SoC platform/codec will be replaced to component soon. But, some function exist in "platform" doesn't exist in "component". Current soc-core has snd_soc_register_component(), but doesn't have snd_soc_add_component() like snd_soc_add_platform(). This patch adds it.
<snip>
+int snd_soc_register_component(struct device *dev, + const struct snd_soc_component_driver *component_driver, + struct snd_soc_dai_driver *dai_drv, + int num_dai) +{ + struct snd_soc_component *component; + + component = kzalloc(sizeof(*component), GFP_KERNEL); + if (!component) { + dev_err(dev, "ASoC: Failed to allocate memory\n"); + return -ENOMEM;
No need to print an error message if kzalloc fails. The core will print it.
+ } + + return snd_soc_add_component(dev, component, component_driver, + dai_drv, num_dai); +} EXPORT_SYMBOL_GPL(snd_soc_register_component);
thanks, Daniel.