14 Dec
2023
14 Dec
'23
9:56 a.m.
On Thu, Dec 14, 2023 at 11:51:50PM +0800, Jianhua Lu wrote:
On Thu, Dec 14, 2023 at 11:11:06AM +0000, Mark Brown wrote:
The expectation is that TDM is set up by the machine driver, not from hw_params - if the TDM setup can be changed from within hw_params then it's hard to see how it's going to interact well with other TDM users on the bus. More usually hw_params() would be influenced by the setup done in set_tdm_slot().
Currently, qcom TDM setup need to read hw_params, if we want to move it to machine driver, we must hardcode some params, but it will reduce reduce readability.
What makes you say that TDM setup needs to read hw_params?